opendroneid / wireshark-dissector

Dissector of Open Drone ID broadcast protocol for Wireshark
Apache License 2.0
47 stars 14 forks source link

bit32.extract Lua 5.4 compatibility #22

Open slovak194 opened 1 week ago

slovak194 commented 1 week ago

Relatively new wireshark (4.4.0-1~ubuntu22.04.0~ppa1) comes with Lua 5.4 which does not have bit32 library anymore. Despite the bitwise ops are present in this version of Lua (and in Wireshark supplied "bit") - but the alternative to bit32.extract function seems to be missing.

This causes "attempt to call nil value lua field extract (global bit32)" error opening odid_wifi_bcn_sample.pcap file in this repo.

A possible fix is to provide "extract" function written with standard bitwise ops, hovewer, compatibility to previous versions will be broken.

Best regards, Oleksandr Slovak