search

openearth / glofrim

Globally Applicable Framework for Integrated Hydrological-Hydrodynamic Modelling (GLOFRIM)
GNU General Public License v3.0
49 stars 28 forks source link

wflow map and bmi transforms do not match #104

Closed DirkEilander closed 4 years ago

DirkEilander commented 4 years ago

As pointed out by @hcwinsemius in wflow_bmi.py#L165 the clone map and bmi maps of wflow have a different North-South orientation. I'm not too happy with the current solution and like to discuss how we can fix this.

@hcwinsemius It seems the approach with flip_transform did not work eventually? Ideas for how to solve this?

hcwinsemius commented 4 years ago

I noticed that a flipud was done in the get_value method of WFL so it was not required eventually. I did implement some additional options to accomodate a flip of the Affine transformation in case that would be needed for future models

DirkEilander commented 4 years ago

OK. I'll keep this issue open to see how we can fix this in a nicer way.

hcwinsemius commented 4 years ago

I am not convinced that this is a GLOFRIM issue. It is a wflow issue that the bmi methods have their origin differently than the model layers itself. So I propose to close this issue. It should be resolved in WFlow instead.