openearth / glofrim

Globally Applicable Framework for Integrated Hydrological-Hydrodynamic Modelling (GLOFRIM)
GNU General Public License v3.0
48 stars 28 forks source link

tried implementing WBcheck; little success #38

Closed JannisHoch closed 6 years ago

JannisHoch commented 6 years ago

problem: to see whether volume set to "rain" equals difference in "vol1", DFM needs to be updated but this again produces outflow which we currently cannot assess; found some variables "q1" and "qtotal_1d2d" but no clue what they are doing; also, found that discharge from CMF is negative when summing - why is that?;

hii600 commented 6 years ago

@ChippChapp thank you for your first trial to check water balance.

I found the description of variable names stored at: dflow/src/bmi_get_var.inc Here, vol0 / vol1 are volume at start / end of time step, respectively. q1 is discharge at end of time step, qtotal_1d2d is used only when 1D SOBEK and 2D FM coupling, that’s why we get NULL pointer in ipynb file.

About negative total discharge. If I run the coupled model 20 time steps, it crashes with numerical instability. It shows unrealistically large water volume. This problem can also be detected in VU_nestedModelling branch (I should have checked more thoroughly), so I guess this is probably related with the modification of nextxy file. We should carefully do this or have to find other way. I’ll examine this problem.

JannisHoch commented 6 years ago

@hii600 didn't know about this file yet, finally the meaning of all the abbreviations is uncovered :)