openearth / glofrim

Globally Applicable Framework for Integrated Hydrological-Hydrodynamic Modelling (GLOFRIM)
GNU General Public License v3.0
46 stars 27 forks source link

cmf outdir #76

Closed DirkEilander closed 6 years ago

DirkEilander commented 6 years ago

There seems to be one small bug with CMF when I run it with the BMI wrapper in the cdsms-compliant branch at the moment. When I run the model the model tries to write the output in /< OUTDIR >/ instead of just < OUTDIR >/

In the namfile my settings look like this:

&NOUTPUT
COUTDIR="./out/"
COUTFLWDIR="/"

But when I look in the log file it has changed the OUTFLWDIR setting to the OUTDIR setting:

&NOUTPUT
COUTDIR="./out/"
COUTFLWDIR="./out/"

It then tries to save the output in ./out/out/

hii600 commented 6 years ago

@DirkEilander Thank you very much for your work. I'll take a look at the problem in several days.

DirkEilander commented 6 years ago

@hii600 Did you manage to have a look at this? if you run a coupled PCR2CMF model using the glofrim_PCR2CMF.ini file from the model_test_data/test_ELBE dir as below, you will notice that the CMF ouputs are saved in ./out/out/ while ./out/ is set in the input_food.temp file.

python glofrim_runner.py run /home/dirk/repos/model_test_data/test_Elbe/glofrim_PCR2CMF.ini --env /home/dirk/repos/glofrim/environment.env -s 2000-01-01 -e 2000-01-10

hii600 commented 6 years ago

@DirkEilander Sorry for the late response. I reproduced the same error as you encountered. However, if I set the output directory outside of the model_test_data directory (and I guess it should be so), I could successfully obtain the outputs in the expected directory.

input_flood.temp

&NOUTPUT
LOUTCDF=.TRUE.
COUTDIR="../../../work/test_Elbe/CMF/"
COUTFLWDIR="../../../work/test_Elbe/CMF/"
JannisHoch commented 6 years ago

@hii600 good to know that you can avoid it this way, but doesn't really sound like it's solved it to me as users still may use "./out/" and then they'll end up in trouble. can you try to fix it or would that take veeeeery long?

hii600 commented 6 years ago

@ChippChapp @DirkEilander Please update your CMF model from the latest git repository (cama-flood_bmi_v3.6.2 ), where I fixed a small bug in specifying output directory. By doing so the doubling problem is now fixed.

JannisHoch commented 6 years ago

@hii600 many thanks for looking into this and also solving it!

DirkEilander commented 6 years ago

Thanks @hii600 for working on this!!