search

openearth / glofrim

Globally Applicable Framework for Integrated Hydrological-Hydrodynamic Modelling (GLOFRIM)
GNU General Public License v3.0
48 stars 28 forks source link

automatically adapt CMF nam-file #90

Closed JannisHoch closed 5 years ago

JannisHoch commented 5 years ago

The DROFUNIT factor in the CMF nam-file should be automatically set to 1 if coupled with PCR. Would avoid quite some unnecessary runs as it may often be forgotten to adapt this setting in the nam-file.

DirkEilander commented 5 years ago

I don't think we should be changing the config files "under the hood". Instead we should use a python library like pint to do automatic unit conversion.

On Fri, Nov 30, 2018, 2:50 PM Jannis Hoch notifications@github.com wrote:

The DROFUNIT factor in the CMF nam-file should be automatically set to 1 if coupled with PCR. Would avoid quite some unnecessary runs as it may often be forgotten to adapt this setting in the nam-file.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openearth/glofrim/issues/90, or mute the thread https://github.com/notifications/unsubscribe-auth/AOqtEFY7gSigl8mHCnSj9PDsIcTLiivOks5u0TfBgaJpZM4Y7tLn .

-- Kind regards, Dirk Eilander

Email: dirk.eilander@gmail.com | LinkedIn: http://lnkd.in/VSS42s | Twitter: @DirkEilander

JannisHoch commented 5 years ago

Alright, sounds good to me too. As long as the results are not 3 order of magnitude smaller because you forgot to change one parameter I am fine with whatever means :)

DirkEilander commented 5 years ago

should we close this issue and open one in which we discuss how to implement unit conversion (e.g. using pint)?