openearth / glofrim

Globally Applicable Framework for Integrated Hydrological-Hydrodynamic Modelling (GLOFRIM)
GNU General Public License v3.0
46 stars 27 forks source link

ldd and subcatch error message #99

Open GovertAlkemade opened 5 years ago

GovertAlkemade commented 5 years ago

When running a wflow glofrim requires a "wflow_ldd.map" and "wflow_subcatch.map" to be present in the static input maps for the given wflow model, if this is not the case an error is raised and glofrim stops running even though the model might not require a ldd or subcatch map.

The checks are in lines 194 and 197 of wfl_bmi.py error

DirkEilander commented 5 years ago

Thanks for making the issue @GovertAlkemade It's probably best to set a warming instead of an error message as the ldd is not always required, but only if there is a coupling with a hydrodynamic model which requires upstream boundary conditions. I'll look into this.