Fix Error Handling On Creation Failure

openebs-archive / device-localpv

CSI Driver for using Local Block Devices

Apache License 2.0

26 stars 17 forks source link

Fix Error Handling On Creation Failure #30

Closed iyashu closed 2 years ago

iyashu commented 3 years ago

I see we are not propagating the volume provisioning error from node agent to controller to enable volume rescheduling on some other node (as we used to do with lvm localpv plugin). Can we fix it to enable rescheduling on provisioning failure to some other node?

https://github.com/openebs/device-localpv/blob/5212adbb17b9089426b00ba1f5da6b1366f2214b/pkg/mgmt/volume/volume.go#L75-L98

akhilerm commented 3 years ago

VolumeError needs to be returned from the node agent similar to done in LVM local PV here.