search

openebs-archive / dynamic-nfs-provisioner

Operator for dynamically provisioning an NFS server on any Kubernetes Persistent Volume. Also creates an NFS volume on the dynamically provisioned server for enabling Kubernetes RWX volumes.
Apache License 2.0
169 stars 58 forks source link

Helm chart nfsStorageClass.enabled property is missing #147

Closed madalinignisca closed 11 months ago

madalinignisca commented 2 years ago

The helm chart has no option to disable creation of the storage class. Would be nice to have this like all other OpenEBS components.

dsharma-dc commented 1 year ago

@madalinignisca The nfs provisioner essentially deals with two storage classes, hence a bit different in that regard. The enabled property you mention as equivalent to other openebs components is applicable for nfsProvisioner section in the helm values.yaml

Is there any particular issue you are facing due to this? If yes, could you please provide more details.

madalinignisca commented 1 year ago

The issue is that you don't have a property in the values file to disable creating the storage class.

In some automation scenarios, I want to create 2 or 3 storage classes myself and don't want this helm chart to create it's own default one.

My case is when we control what classes storage classes we create after to point to different have them use different storage classes for backend (example one on maya store and another one on the cloud provider provided one).

The default storage class this helm chart creates, either you have to ignore it, or if you edit it, gets overwriten on next update.

dsharma-dc commented 1 year ago

@madalinignisca I see. It's a convenience enhancement. Would you be able to create a PR to take care of this? Let me know if you can't, we'll have to mark it out as an item in some upcoming changelist.