openebs-archive / dynamic-nfs-provisioner

Operator for dynamically provisioning an NFS server on any Kubernetes Persistent Volume. Also creates an NFS volume on the dynamically provisioned server for enabling Kubernetes RWX volumes.
Apache License 2.0
168 stars 58 forks source link

feat(event): update ua to ga4 analytics #174

Closed Abhinandan-Purkait closed 9 months ago

Abhinandan-Purkait commented 9 months ago

Refs

Description

Moving measurement protocol from UA to GA4.

API Docs

Fixes:- https://github.com/openebs/dynamic-nfs-provisioner/issues/175

codecov-commenter commented 9 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b35af76) 50.17% compared to head (7ca320c) 49.94%. Report is 4 commits behind head on develop.

Files Patch % Lines
provisioner/provisioner.go 0.00% 8 Missing :warning:
provisioner/controller.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #174 +/- ## =========================================== - Coverage 50.17% 49.94% -0.24% =========================================== Files 38 38 Lines 2792 2805 +13 =========================================== Hits 1401 1401 - Misses 1285 1298 +13 Partials 106 106 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dsharma-dc commented 9 months ago

@Abhinandan-Purkait Perhaps you should squash the commit 7ca320c into some previous commit.

Abhinandan-Purkait commented 9 months ago

@Abhinandan-Purkait Perhaps you should squash the commit 7ca320c into some previous commit.

@dsharma-dc I will do a squash and merge. Waiting for the ci to complete.