Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
This PR fixes CStor volume provisioning issue. Currently
REST request to create CStor volume will fail if request
is made without creating PVC because of following bug:
When the REST API is called to create volume it will
verify whether request payload has PVC name. If PVC
name doesn't exist then it will skip execution of
cstor-volume-create-puttargetservice-default runtask
but with latest changes above runtask is not skipped and
leads to failure in the creation of CStor volume.
For more info: #1735
What this PR does?:
This PR skips the execution of cstor-volume-create-puttargetservice-default
runtask if creation request is made without creating PVC.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Build and deployed the maya-apiserver and made curl request to create volume
Any additional information for your reviewer? :
The creation of cStor volume without PVC creation
is a use case related to cStor restore.
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
[ ] Fixes #
[x] PR Title follows the convention of <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
Signed-off-by: mittachaitu sai.chaithanya@mayadata.io
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?: This PR fixes CStor volume provisioning issue. Currently REST request to create CStor volume will fail if request is made without creating PVC because of following bug:
cstor-volume-create-puttargetservice-default
runtask but with latest changes above runtask is not skipped and leads to failure in the creation of CStor volume. For more info: #1735What this PR does?: This PR skips the execution of
cstor-volume-create-puttargetservice-default
runtask if creation request is made without creating PVC.Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? : The creation of cStor volume without PVC creation is a use case related to cStor restore.
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>