openebs-archive / maya

Manage Container Attached Storage (CAS) - Data Engines in Kubernetes
https://docs.openebs.io
Apache License 2.0
184 stars 201 forks source link

feat(analytic): support to use custom server for analytics #1808

Closed mynktl closed 3 years ago

mynktl commented 3 years ago

What this PR does?: This PR refactors the usage package APIs.

Caller can use the following updated API to send analytics to google:

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? : Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

kmova commented 3 years ago

This PR needs update in all the dependent repos. This will be taken up as part of the next release.

vharsh commented 3 years ago

This PR needs update in all the dependent repos. This will be taken up as part of the next release.

Is moving it out into a separate feature-repo not in the plan, such that this becomes a vendor-ed library so that effort is reduced to a simple dependency version bump up? Was the earlier plan modified because of different ways each module will expose the .version variable location in constants of the binary?

kmova commented 3 years ago

this is not required anymore.