openebs-archive / maya

Manage Container Attached Storage (CAS) - Data Engines in Kubernetes
https://docs.openebs.io
Apache License 2.0
184 stars 201 forks source link

fix(blockdeviceclaim-build-file): Add new build function to add any BDC selectors #1815

Closed Ab-hishek closed 3 years ago

Ab-hishek commented 3 years ago

Signed-off-by: Abhishek Agarwal abhishek.agarwal@mayadata.io

Why is this PR required? What issue does it fix?: Adds a new function to add Selectors to BDC. Currently only one fixed selector can be added to the BDC and that is "openebs.io/block-device-tag".

What this PR does?: The function added will allow to add any number of selector labels to the BDC by passing a map of string key and values.

Does this PR require any upgrade changes?: No.

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :

Checklist:

kmova commented 3 years ago

@Ab-hishek -- can you push this change into the openebs/api as well here: https://github.com/openebs/api/blob/master/pkg/apis/openebs.io/v1alpha1/blockdeviceclaimbuilder.go