Closed akhilerm closed 2 years ago
@cospotato Can you help with reviews on this PR.
Merging #657 (3c33f2e) into develop (498c632) will decrease coverage by
0.24%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## develop #657 +/- ##
===========================================
- Coverage 45.04% 44.79% -0.25%
===========================================
Files 79 79
Lines 3969 3971 +2
===========================================
- Hits 1788 1779 -9
- Misses 2010 2024 +14
+ Partials 171 168 -3
Impacted Files | Coverage Δ | |
---|---|---|
cmd/ndm_daemonset/probe/blkidprobe.go | 0.00% <0.00%> (ø) |
|
cmd/ndm_daemonset/probe/addhandler.go | 67.97% <0.00%> (-2.95%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 498c632...3c33f2e. Read the comment docs.
@akhilerm OK. It's my pleasure.
Why is this PR required? What issue does it fix?: udev is not able to fetch the partition entry uuid in CentOS 7, since PARTUUID is not supported in libblkid 2.23.
What this PR does?: Uses the libblkid from the base container to fetch the partition entry UUID, if it was not filled in by udev
Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? : Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>