openebs-archive / node-disk-manager

Kubernetes Storage Device Management
https://openebs.io/docs
Apache License 2.0
182 stars 113 forks source link

[stable/ndm]: add node selector and toleration to ndm exporter #668

Closed akhilerm closed 2 years ago

akhilerm commented 2 years ago

Fixes : openebs/charts#301

Signed-off-by: Akhil Mohan akhil.mohan@datacore.com

akhilerm commented 2 years ago

Updated the indent in image pull secrets. @sonasingh46 Do you remember why we made image pull secrets different from other keys like tolerations and nodeselector. When I tested, I see that both of the methods are working.

akhilerm commented 2 years ago

@xUnholy and @Ab-hishek can you take a look at the PR?

pawanpraka1 commented 2 years ago

@akhilerm can we merge this one? RC1 branching is already done.