Open nobiit opened 2 years ago
Merging #679 (128de36) into develop (6863cc2) will increase coverage by
0.31%
. The diff coverage is0.00%
.:exclamation: Current head 128de36 differs from pull request most recent head a02ddc6. Consider uploading reports for the commit a02ddc6 to get more accurate results
@@ Coverage Diff @@
## develop #679 +/- ##
===========================================
+ Coverage 45.01% 45.32% +0.31%
===========================================
Files 79 79
Lines 3992 3993 +1
===========================================
+ Hits 1797 1810 +13
+ Misses 2028 2014 -14
- Partials 167 169 +2
Impacted Files | Coverage Δ | |
---|---|---|
pkg/select/blockdevice/select.go | 0.00% <0.00%> (ø) |
|
cmd/ndm_daemonset/probe/udevprobe.go | 50.00% <0.00%> (+1.55%) |
:arrow_up: |
cmd/ndm_daemonset/probe/addhandler.go | 70.91% <0.00%> (+2.94%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Pull Request template
Why is this PR required? What issue does it fix?: There is currently no way to get a sparse Device What this PR does?: Combined with https://github.com/openebs/dynamic-localpv-provisioner/pull/145. It provides a way to get the device sparse by specifying the DeviceType explicitly
Does this PR require any upgrade changes?: No If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? : Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>
PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>
.Where: Most common types are:
feat
- for new features, not a new feature for build scriptfix
- for bug fixes or improvements, not a fix for build scriptchore
- changes not related to production codedocs
- changes related to documentationstyle
- formatting, missing semi colons, linting fix etc; no significant production code changestest
- adding missing tests, refactoring tests; no production code changerefactor
- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changescherry-pick
- if PR is merged in develop branch and raised to release branch(like v0.4.x)IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.