openebs / community

OpenEBS community resources
Apache License 2.0
3 stars 2 forks source link

refactor: remove admin role and clarify maintainer #93

Closed tiagolobocastro closed 1 month ago

tiagolobocastro commented 1 month ago

Removes the Admin Roles as Maintainers are essentially Admins. A maintainer is only expected to make substancial contributions, but not necessarily in a full-time position. Add missing special maintainer from table.

orville-wright commented 1 month ago

I'm not following this change.

The Admin role is a CNCF function that CNCF gives to the maintainers so that they can manage the project on behalf of CNCF so that CNCF doesn't have to spend their time managing projects (it's a kind of special delegated CNCF leadership status). Therefore Admins and maintainers are the superusers of the project and are kind of similar, but not 100% the same.

It's not clear how ADMIN and MAINTAINER roles will be differentiated in your proposal and how the 2 roles are managed?

Also, I'd like to see some examples of other CNCF projects that have done this, to feel comfortable that this is a generally accepted common practice within CNCF projects that leads to healthy governance practices.

Finally, why are we obsessing about this kind of structural changes when there's much bigger & more important t problems to solve, like: Promotion to Sandbox.

tiagolobocastro commented 1 month ago

It's not clear how ADMIN and MAINTAINER roles will be differentiated in your proposal and how the 2 roles are managed?

Admin role is removed and becomes part of Maintainer role:

Maintainers also perform the admin non-code-related Github tasks such as updating permissions, configuring integrations and other administrative tasks.

Also, I'd like to see some examples of other CNCF projects that have done this, to feel comfortable that this is a generally accepted common practice within CNCF projects that leads to healthy governance practices.

This brings it more in line with other CNCF projects

orville-wright commented 1 month ago

@tiagolobocastro cab you provide a few examples of the CNCF projects you allude to that also operate this way?

Also, please confirm if I understand this correctly - this change now gives all Maintainers the power of CNCF project admins?

tiagolobocastro commented 1 month ago

@tiagolobocastro cab you provide a few examples of the CNCF projects you allude to that also operate this way?

helm, jaeger, etcd, etc... I think it'd harder to find one which doesn't operate this way.

Also, please confirm if I understand this correctly - this change now gives all Maintainers the power of CNCF project admins?

Yes, although that's already kinda true today. CNCF can give admin rights to a maintainer on request. So this effectively means a maintainer is an admin, there's no need to separate this, and as you can see from various other CNCF projects, they usually don't.

orville-wright commented 1 month ago

Thanks for the supporting info @tiagolobocastro - its seems good that we align with CNCF best practices as much a we can.