Why is this PR required? What issue does it fix?:
The lvm-node service selector field in helm template points to podLabels value which is empty by default. Hence when lvm-localpv is deployed using helm the lvm-node-service endpoints remain empty as the service's selector field is empty and not able to indetify any targets. With this issue, when monitoring is enabled for lvm, the servicemonitors are not able to identify its targets and therefore metrics scrapping doesn't occur.
What this PR does?:
This PR adds podLabels value in values.yaml so that when lvm is installed via helm, the service selector field does not remain empty and endpoints are discovered.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
[ ] Fixes #
[x] PR Title follows the convention of <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
Signed-off-by: Abhishek Agarwal abhishek.agarwal@mayadata.io
Why is this PR required? What issue does it fix?: The lvm-node service selector field in helm template points to podLabels value which is empty by default. Hence when lvm-localpv is deployed using helm the lvm-node-service endpoints remain empty as the service's selector field is empty and not able to indetify any targets. With this issue, when monitoring is enabled for lvm, the servicemonitors are not able to identify its targets and therefore metrics scrapping doesn't occur.
What this PR does?: This PR adds podLabels value in values.yaml so that when lvm is installed via helm, the service selector field does not remain empty and endpoints are discovered.
Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? : Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>