openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
248 stars 93 forks source link

docs(snapshot): document dm-snapshot kernel module is required. #166

Closed flokli closed 2 years ago

flokli commented 2 years ago

Why is this PR required?: https://github.com/openebs/lvm-localpv/issues/163

What this PR does?: It documents the fact the dm-snapshot kernel module needs to be loaded

Does this PR require any upgrade changes?: no

If the changes in this PR are manually verified, list down the scenarios covered:: I added a modprobe dm-snapshot; echo dm-snapshot >> /etc/modules to the installation script and verified this works afterwards.

Any additional information for your reviewer? : To fully solve https://github.com/openebs/lvm-localpv/issues/163, there still needs to be some more graceful handling (no crazy busylooping) if the module is not present. Maybe backoff in case the invoked command doesn't succeed)

Checklist:

pawanpraka1 commented 2 years ago

@flokli, would you like to mention your use case in our adopters(openebs/openebs#2719) file.

zimbatm commented 2 years ago

I just noticed that https://github.com/openebs/lvm-localpv#prerequisites is also missing that requirement.

flokli commented 2 years ago

@zimbatm, can you send a PR adding it there, too?

flokli commented 2 years ago

@zimbatm I opened https://github.com/openebs/lvm-localpv/pull/168.