Closed flokli closed 2 years ago
@flokli, would you like to mention your use case in our adopters(openebs/openebs#2719) file.
I just noticed that https://github.com/openebs/lvm-localpv#prerequisites is also missing that requirement.
@zimbatm, can you send a PR adding it there, too?
@zimbatm I opened https://github.com/openebs/lvm-localpv/pull/168.
Why is this PR required?: https://github.com/openebs/lvm-localpv/issues/163
What this PR does?: It documents the fact the
dm-snapshot
kernel module needs to be loadedDoes this PR require any upgrade changes?: no
If the changes in this PR are manually verified, list down the scenarios covered:: I added a
modprobe dm-snapshot; echo dm-snapshot >> /etc/modules
to the installation script and verified this works afterwards.Any additional information for your reviewer? : To fully solve https://github.com/openebs/lvm-localpv/issues/163, there still needs to be some more graceful handling (no crazy busylooping) if the module is not present. Maybe backoff in case the invoked command doesn't succeed)
Checklist:
<type>(<scope>): <subject>