Closed nkwangleiGIT closed 2 years ago
@nkwangleiGIT can you DCO signoff this PR?
Signed-off-by: nkwangleiGIT nkwanglei@126.com done
@nkwangleiGIT Would you like to mention your use case in our adopters(https://github.com/openebs/openebs/issues/2719) file.
@pawanpraka1 sure, I just need to add our user case here https://github.com/openebs/openebs/issues/2719?
@nkwangleiGIT that is right. You can put a comment describing your use case.
sure, done
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?: Fix issue https://github.com/openebs/lvm-localpv/issues/188
What this PR does?: Use SpaceWeighted as the default scheduler
Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered:: 1、Install openebs lvm 2、Create lvm storageclass(Use two K8S nodes for lvm provision) 3、Create PVC to use the sc above to provision LVM volume, to make sure it use the SpaceWeighted when schedule LVM volume
Any additional information for your reviewer? : Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>
PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>
.Where:
type
is defining if release will be triggering after merging submitted changes, details in CONTRIBUTING.md. Most common types are:feat
- for new features, not a new feature for build scriptfix
- for bug fixes or improvements, not a fix for build scriptchore
- changes not related to production codedocs
- changes related to documentationstyle
- formatting, missing semi colons, linting fix etc; no significant production code changestest
- adding missing tests, refactoring tests; no production code changerefactor
- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changesscope
is a single word that best describes where the changes fit. Most common scopes are like:localpv
,jiva
,cstor
)provisioning
,backup
,restore
,exporter
)api
,webhook
,cast
,upgrade
)tests
,bdd
)version
,build
,log
,travis
)subject
is a single line brief description of the changes made in the pull request.