openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
245 stars 92 forks source link

Fix(scheduler): use SpaceWeighted as the default scheduler #187

Closed nkwangleiGIT closed 2 years ago

nkwangleiGIT commented 2 years ago

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?: Fix issue https://github.com/openebs/lvm-localpv/issues/188

What this PR does?: Use SpaceWeighted as the default scheduler

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered:: 1、Install openebs lvm 2、Create lvm storageclass(Use two K8S nodes for lvm provision) 3、Create PVC to use the sc above to provision LVM volume, to make sure it use the SpaceWeighted when schedule LVM volume

Any additional information for your reviewer? : Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING

The PR title message must follow convention: <type>(<scope>): <subject>.

Where:

pawanpraka1 commented 2 years ago

@nkwangleiGIT can you DCO signoff this PR?

nkwangleiGIT commented 2 years ago

Signed-off-by: nkwangleiGIT nkwanglei@126.com done

pawanpraka1 commented 2 years ago

@nkwangleiGIT Would you like to mention your use case in our adopters(https://github.com/openebs/openebs/issues/2719) file.

nkwangleiGIT commented 2 years ago

@pawanpraka1 sure, I just need to add our user case here https://github.com/openebs/openebs/issues/2719?

pawanpraka1 commented 2 years ago

@nkwangleiGIT that is right. You can put a comment describing your use case.

nkwangleiGIT commented 2 years ago

sure, done