openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
245 stars 92 forks source link

Use SpaceWeighted as the default scheduler #188

Closed nkwangleiGIT closed 3 months ago

nkwangleiGIT commented 2 years ago

What steps did you take and what happened: [A clear and concise description of what the bug is, and what commands you ran.] As we introduced a new SpaceWeighted scheduler, and it can do better LVM volume binding, see the details in the PR below: https://github.com/openebs/lvm-localpv/pull/178 But the default is still CapacityWeighted as we set the default value when initialize the params.

What did you expect to happen: Use SpaceWeighted as the default scheduler.

The output of the following commands will help us better understand what's going on: (Pasting long output into a GitHub gist or other Pastebin is fine.)

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

dsharma-dc commented 3 months ago

@abhilashshetty04 This can perhaps be closed if the enhancement is already merged as seen from linked PR?

abhilashshetty04 commented 3 months ago

@dsharma-dc , Yes we are using spaceWeighted algorithm by default. Closing this issue.