openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
245 stars 92 forks source link

Controller refactor to use dynamic client instead of generated code #189

Closed abhilashshetty04 closed 2 years ago

abhilashshetty04 commented 2 years ago

This project uses controllers which watches over 3 cr's. Controller plugin(lvmnodes). Node plugin(lvmvolumes, lvmnodes, lvmsnapshots)

Currently all these controllers are using generated code to implement client. We could use dynamic client from client-go which would reduce code foot prints and will make code more readable as well. In addition to that i am adding only 1 method which would create and return controllers as opposed to using multiple methods to build controller.

Progress on each controller:

Node plugin:

Controller plugin:

PR: https://github.com/openebs/lvm-localpv/pull/186

abhilashshetty04 commented 2 years ago

Pr is merged. Closing the issue.