openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
245 stars 92 forks source link

Why does openebs-lvm-controller use StatefulSet ? #196

Closed iswbm closed 3 months ago

iswbm commented 2 years ago

When the node where openebs-lvm-controller is located goes down, the pod of lvm-controller will always be in terminating and will not be automatically started on other nodes.

So I wonder why does openebs-lvm-controller use StatefulSet ?

Are there any special considerations?

niladrih commented 11 months ago

I remember a discussion where this decision was made. But I just cannot recall the reason at the moment. @pawanpraka1 @akhilerm @shubham14bajpai @kmova -- is there a reason for this decision?

evgkrsk commented 11 months ago

Vote for Deployment.

dsharma-dc commented 4 months ago

@niladrih This issue can be closed now I think because the type has been changed to Deployment in PR #286 ?

niladrih commented 3 months ago

This was fixed in v1.5.0 and is a part of OpenEBS 4.0.