openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
245 stars 92 forks source link

make the installation of snapshot.storage.k8s.io CRDs optional #203

Closed phhutter closed 12 months ago

phhutter commented 2 years ago

Hi,

Could we make the installation of the following CRDs optional?

https://github.com/openebs/lvm-localpv/blob/develop/deploy/helm/charts/crds/volumesnapshotclasses.yaml https://github.com/openebs/lvm-localpv/blob/develop/deploy/helm/charts/crds/volumesnapshotcontents.yaml https://github.com/openebs/lvm-localpv/blob/develop/deploy/helm/charts/crds/volumesnapshots.yaml

Is there a reason why you have included them in the openEBS helmchart? These resources are usually maintained and managed by the underlying kubernetes distribution. In case of OpenShift, it will automatically revert back the modifications made by your helmchart. This could be problematic if you use ArgoCD and have it on autosync.

abhilashshetty04 commented 12 months ago

Done in https://github.com/openebs/lvm-localpv/pull/243