feat(lvm-localpv): make the installation of snapshot.storage.k8s.io CRDs optional

phhutter commented 2 years ago

Why is this PR required? What issue does it fix?: change for #203

What this PR does?: This PR will enable the possibility to disable the installation of the volumesnapshot CRDs. To prevent any regressions, the default has been set to true. These resources are usually maintained and managed by the underlying kubernetes distribution. In case of OpenShift, it will automatically revert back the modifications made by this helmchart. This could be problematic if you use ArgoCD and have it on autosync.

Checklist:

[x] Fixes #203
[x] PR Title follows the convention of <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

ryanfaircloth commented 1 year ago

this is infact impact me with argocd could this get merged with a small release

niladrih commented 1 year ago

Closing this PR. This commit has been included in PR https://github.com/openebs/lvm-localpv/pull/243.

openebs / lvm-localpv

feat(lvm-localpv): make the installation of snapshot.storage.k8s.io CRDs optional #205