fix(helm chart): Fix ImagePullSecret indentation

[Lirt]

Why is this PR required? What issue does it fix?: This PR fixes a bug in helm chart where the chart cannot be installed if imagePullSecret is specified.

What this PR does?: Fixes indentation of imagePullSecret in helm chart.

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered:: $ helm upgrade --install --values values.yaml --debug --wait --dry-run openebs .

values.yaml:

---
imagePullSecrets:
- name: my-image-pull-secret

Output:

history.go:56: [debug] getting history for release openebs
Release "openebs" does not exist. Installing it now.
install.go:178: [debug] Original chart version: ""
install.go:195: [debug] CHART PATH: <REDACTED>/lvm-localpv/deploy/helm/charts

install.go:210: [debug] WARNING: This chart or one of its subcharts contains CRDs. Rendering may fail or contain inaccuracies.
Error: YAML parse error on lvm-localpv/templates/lvm-controller.yaml: error converting YAML to JSON: yaml: line 137: did not find expected key
helm.go:84: [debug] error converting YAML to JSON: yaml: line 137: did not find expected key
YAML parse error on lvm-localpv/templates/lvm-controller.yaml
helm.sh/helm/v3/pkg/releaseutil.(*manifestFile).sort
    helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:146
helm.sh/helm/v3/pkg/releaseutil.SortManifests
    helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:106
helm.sh/helm/v3/pkg/action.(*Configuration).renderResources
    helm.sh/helm/v3/pkg/action/action.go:165
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
    helm.sh/helm/v3/pkg/action/install.go:259
main.runInstall
    helm.sh/helm/v3/cmd/helm/install.go:264
main.newUpgradeCmd.func2
    helm.sh/helm/v3/cmd/helm/upgrade.go:121
github.com/spf13/cobra.(*Command).execute
    github.com/spf13/cobra@v1.4.0/command.go:856
github.com/spf13/cobra.(*Command).ExecuteC
    github.com/spf13/cobra@v1.4.0/command.go:974
github.com/spf13/cobra.(*Command).Execute
    github.com/spf13/cobra@v1.4.0/command.go:902
main.main
    helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
    runtime/proc.go:255
runtime.goexit
    runtime/asm_amd64.s:1581

Any additional information for your reviewer? : No

Checklist:

• [x] Fixes #
• [x] PR Title follows the convention of <type>(<scope>): <subject>
• [x] Has the change log section been updated? -- No - nothing required
• [x] Commit has unit tests
• [x] Commit has integration tests
• [x] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
• [x] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: Ondrej Vasko o.vasko@pan-net.eu

[Lirt]

Hello,

This PR will also require update of dependency inside openebs umbrella chart.

I am not sure if appVersion should be bumped in Chart.yaml here. Please let me know.

[Lirt]

Thank you