search

openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
235 stars 92 forks source link

feat(NodeController): made node polling interval configurable #256

Closed omric-runai closed 10 months ago

omric-runai commented 10 months ago

Why is this PR required? What issue does it fix?: This PR makes the polling interval of the node configurable, allowing users to get a higher update rate for their csistoragecapacities, and preventing scheduling issue.

What this PR does?: This PR adds a new flag, --node-polling-interval, with a default value of 60s (same as the currant hard-coded value), which controls the polling rate of the node.

Does this PR require any upgrade changes?: No.

If the changes in this PR are manually verified, list down the scenarios covered::

  1. Verified that the default remains 60s, when not using the flag.
  2. Verified that changing the value of the flag changes the polling rate.

Any additional information for your reviewer? : N/A

Checklist:

abhilashshetty04 commented 10 months ago

Hi @omric-runai , Thanks for the PR. lgtm

avishnu commented 10 months ago

@avishnu @abhilashshetty04 Since this is configurable, I think we need a helm value and template change to accommodate this?

Yes, we need a configurable parameter in the helm values.yaml

Abhinandan-Purkait commented 10 months ago

@omric-runai Thanks for the PR. Would you be interested in raising a helm chart change for allowing configuring this from Helm Chart? You can raise a separate PR for that if you want.