Closed emiran-orange closed 9 months ago
Would it make sense to add lvmController.snapshotController.enabled
and lvmController.snapshotter.enabled
to condition the addition both containers to controller pod ? If so, I can drop a PR about it
@emiran-orange Is this to disable the snapshot feature? I am not sure if we want that to be configurable.
The crd.volumeSnapshot=False
would be considered valid combination if the cluster already has the snapshot crds. It's not desirable to disable the crd installation if crds are not present in the cluster already.
Or are you saying even if the crds are present and we set crd.volumeSnapshot=False
, the csi containers still fail?
@Abhinandan-Purkait Thanks for the highlight.
Disabling the snapshot feature was what I had in mind but I understand your position. I'm working on a soft mutitenant cluster it seems that I can achieve the same by not defining any volumesnapshotclass
@Abhinandan-Purkait I noticed that volumeSnapshot CRDs are only conditioned on crd.volumeSnapshot while there is also crd.enabled which is not interpreted anywhere...
Is it on purpose ?
Okay. crd.enabled
is a helm macro, which helm understands, that's the reason you aren't seeing it in any template. That is there to disable installation of all crds. FYI we have some other crds that we use for LVM. Setting crd.enabled
to false will not install any crds that are a part of this helm chart. Hope that answers your question.
Thanks for your time and sorry for the disturbance of this (non)issue.
What steps did you take and what happened: Install chart with
crd.volumeSnapshot=False
, wait for container snapshot-controller to crash with the following error:What did you expect to happen: Ability not to add snapshot-controller to pod
The output of the following commands will help us better understand what's going on:
kubectl logs -f openebs-lvm-controller-0 -n kube-system -c openebs-lvm-plugin
Not relevantkubectl logs -f openebs-lvm-node-[xxxx] -n kube-system -c openebs-lvm-plugin
Not relevantkubectl get pods -n kube-system
kubectl get lvmvol -A -o yaml
Not relevantAnything else you would like to add: volumeSnapshot CRDs are only conditioned on
crd.volumeSnapshot
while there is aloscrd.enabled
which is not interpreted anywhere...Environment:
kubectl version
): Not relevant/etc/os-release
): Not relevant