Closed houwenchen closed 6 months ago
:exclamation: No coverage uploaded for pull request base (
develop@9e0ac5b
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #266 +/- ##
=========================================
Coverage ? 2.80%
=========================================
Files ? 61
Lines ? 4107
Branches ? 0
=========================================
Hits ? 115
Misses ? 3983
Partials ? 9
I think this change should use the script /buildscripts/test-cov.sh
in the 'test' Makefile target, and then try to publish the codecov result without a token? Token is usually required when there are chances of a large number of github api calls, I think.
@niladrih , it's just like docker token to upload docker image.
Has been cherry-picked.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? : Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>
PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>
.Where:
type
is defining if release will be triggering after merging submitted changes, details in CONTRIBUTING.md. Most common types are:feat
- for new features, not a new feature for build scriptfix
- for bug fixes or improvements, not a fix for build scriptchore
- changes not related to production codedocs
- changes related to documentationstyle
- formatting, missing semi colons, linting fix etc; no significant production code changestest
- adding missing tests, refactoring tests; no production code changerefactor
- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changesscope
is a single word that best describes where the changes fit. Most common scopes are like:localpv
,jiva
,cstor
)provisioning
,backup
,restore
,exporter
)api
,webhook
,cast
,upgrade
)tests
,bdd
)version
,build
,log
,travis
)subject
is a single line brief description of the changes made in the pull request.