openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
251 stars 96 forks source link

solve cicd issue #266

Closed houwenchen closed 6 months ago

houwenchen commented 11 months ago

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:

What this PR does?:

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? : Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING

The PR title message must follow convention: <type>(<scope>): <subject>.

Where:

codecov-commenter commented 11 months ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@9e0ac5b). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             develop    #266   +/-   ##
=========================================
  Coverage           ?   2.80%           
=========================================
  Files              ?      61           
  Lines              ?    4107           
  Branches           ?       0           
=========================================
  Hits               ?     115           
  Misses             ?    3983           
  Partials           ?       9           
niladrih commented 11 months ago

I think this change should use the script /buildscripts/test-cov.sh in the 'test' Makefile target, and then try to publish the codecov result without a token? Token is usually required when there are chances of a large number of github api calls, I think.

houwenchen commented 11 months ago

@niladrih , it's just like docker token to upload docker image.

Abhinandan-Purkait commented 6 months ago

Has been cherry-picked.