openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
235 stars 92 forks source link

fix(charts): Corrected invalid YAML in description tags #270

Closed maxs-rose closed 7 months ago

maxs-rose commented 8 months ago

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:

Some description tags had an invalid structure for multi line strings. For Example:

description: 'Some
description`

Multi line single quoted flows require at least 1 level of indentation or else a parser should treat the first word on the new line as an implicit key.

Valid example:

description: 'Some
  description'

What this PR does?:

Correct invalid yaml for multi line descriptions

Does this PR require any upgrade changes?: No

Checklist:

abhilashshetty04 commented 8 months ago

@maxs-rose , Thanks for your contribution. Since you have done chart version bump we will cherry pick this into new PR.

Abhinandan-Purkait commented 7 months ago

Included in #277

niladrih commented 7 months ago

Those CRDs are sourced from kubernetes-sigs/external-snapshotter. Those CRDs are generated using kube-builder's controller-gen tool. If you'd like to address this issue at its core, that's where you'd want look. This doesn't affect the lvm-localpv installers (yamls) in any way, these yamls are meant to satify kubernetes' API validation, external linter criteria are a non-goal.

cc: @avishnu