openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
235 stars 92 forks source link

fix(charts): remove extra hyphen to make helm linter pass #272

Closed cmontemuino closed 7 months ago

cmontemuino commented 8 months ago

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:

Template deploy/helm/charts/templates/rbac.yaml is making helm lint to fail.

What this PR does?:

The hyphen at the end of the closing brackets is responsible for chomping all the whitespaces after the brackets. Thus, a previous YAML separator gets into the same line as the apiVersion element from the resource enable by the if statement.

Does this PR require any upgrade changes?:

No.

If the changes in this PR are manually verified, list down the scenarios covered::

cd deploy/helm/charts
helm lint .

Any additional information for your reviewer? : Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

Abhinandan-Purkait commented 7 months ago

Hi @cmontemuino Thanks for the PR. Since your changes would need a helm chart bump we would cherry-pick your commit to a version bump PR.

Abhinandan-Purkait commented 7 months ago

Included in #277