openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
235 stars 92 forks source link

refactor(charts): move CRDs to a subchart #284

Closed niladrih closed 3 months ago

niladrih commented 3 months ago

Changes:

PRs with similar change:

Abhinandan-Purkait commented 3 months ago

@niladrih We might want to consider this PR. https://github.com/openebs/lvm-localpv/pull/258

Abhinandan-Purkait commented 3 months ago

@niladrih You also need to change this file probably. https://github.com/openebs/lvm-localpv/blob/develop/deploy/lvm-operator.yaml and then we can go for a test?

niladrih commented 3 months ago

@niladrih You also need to change this file probably. https://github.com/openebs/lvm-localpv/blob/develop/deploy/lvm-operator.yaml and then we can go for a test?

Put it in a different PR: https://github.com/openebs/lvm-localpv/pull/286

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.29%. Comparing base (f3e9cd0) to head (a1d4915). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #284 +/- ## ============================================ + Coverage 23.50% 98.29% +74.79% ============================================ Files 12 1 -11 Lines 3008 529 -2479 ============================================ - Hits 707 520 -187 + Misses 2288 5 -2283 + Partials 13 4 -9 ``` | [Flag](https://app.codecov.io/gh/openebs/lvm-localpv/pull/284/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openebs) | Coverage Δ | | |---|---|---| | [bddtests](https://app.codecov.io/gh/openebs/lvm-localpv/pull/284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openebs) | `98.29% <ø> (+0.53%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/openebs/lvm-localpv/pull/284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openebs) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openebs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.