openebs / lvm-localpv

Dynamically provision Stateful Persistent Node-Local Volumes & Filesystems for Kubernetes that is integrated with a backend LVM2 data storage stack.
Apache License 2.0
257 stars 97 forks source link

namespace rename breaks the helm chart and daemonsets #336

Open kranurag7 opened 1 month ago

kranurag7 commented 1 month ago

https://github.com/openebs/lvm-localpv/pull/333 (as mentioned in the patch template that this is not compatible) I wanted to understand what is the correct one?

Looking at the current state of the repo gives me two indication, first that you want to move to OPENEBS_NAMESPACE (ref: https://github.com/openebs/lvm-localpv/blob/45e0fbdd6af38f3025132fff5b6d10c3c2eec1fb/legacy-upgrade/README.md?plain=1#L26)

then again looking at patch 333, this was reverted. The revert needs some more work as of now. Especially this line needs to be changed too (ref: https://github.com/openebs/lvm-localpv/blob/45e0fbdd6af38f3025132fff5b6d10c3c2eec1fb/pkg/lvm/volume.go#L38) and the test suite needs to be bumped to use LVM_NAMESPACE

Now before I proceed to making this small changes and raise a patch, I wanted to understand which one out of OPENEBS_NAMESPACE and LVM_NAMESPACE will be used going forward? Happy to send a patch to fix this but this requires discussion first given this is a breaking change.

Environment:

tiagolobocastro commented 1 week ago

Has this been resolved now? CC @niladrih @abhilashshetty04