Now before I proceed to making this small changes and raise a patch, I wanted to understand which one out of OPENEBS_NAMESPACE and LVM_NAMESPACE will be used going forward? Happy to send a patch to fix this but this requires discussion first given this is a breaking change.
Environment:
LVM Driver version: It's 1.6.2 for me and I'm building an image by checking 1.6.2 tag.
Kubernetes version (use kubectl version):
Kubernetes installer & version: 1.30 k3s cluster
Cloud provider or hardware configuration: None (it's a Ubuntu instance running on AWS)
OS (e.g. from /etc/os-release): Ubuntu 24.04 LTS it is.
https://github.com/openebs/lvm-localpv/pull/333 (as mentioned in the patch template that this is not compatible) I wanted to understand what is the correct one?
Looking at the current state of the repo gives me two indication, first that you want to move to OPENEBS_NAMESPACE (ref: https://github.com/openebs/lvm-localpv/blob/45e0fbdd6af38f3025132fff5b6d10c3c2eec1fb/legacy-upgrade/README.md?plain=1#L26)
then again looking at patch 333, this was reverted. The revert needs some more work as of now. Especially this line needs to be changed too (ref: https://github.com/openebs/lvm-localpv/blob/45e0fbdd6af38f3025132fff5b6d10c3c2eec1fb/pkg/lvm/volume.go#L38) and the test suite needs to be bumped to use LVM_NAMESPACE
Now before I proceed to making this small changes and raise a patch, I wanted to understand which one out of
OPENEBS_NAMESPACE
andLVM_NAMESPACE
will be used going forward? Happy to send a patch to fix this but this requires discussion first given this is a breaking change.Environment:
kubectl version
):/etc/os-release
): Ubuntu 24.04 LTS it is.