Helm Chart - Check prometheus CRD availability before creating ServiceMonitor - PodMonitor - PrometheusRule resources

openebs / monitoring

OpenEBS Monitoring add-on. A set of Grafana, Prometheus, and alert manager plugins.

Apache License 2.0

26 stars 20 forks source link

Helm Chart - Check prometheus CRD availability before creating ServiceMonitor - PodMonitor - PrometheusRule resources #107

Open cmontemuino opened 5 months ago

cmontemuino commented 5 months ago

Given that the prometheus-stack dependency can be disabled (see condition: kube-prometheus-stack.install), adding a couple of guardrails to prometheus resources might make sense:

templates/podmonitors.yaml
templates/prometheusRules.yaml
templates/servicemonitors.yaml

cmontemuino commented 5 months ago

I can open a PR if that helps.

datacore-vvarakantham commented 5 months ago

Sure, please proceed to open a PR.

cmontemuino commented 5 months ago

Hi @datacore-vvarakantham, I've just opened an PR to address this issue: https://github.com/openebs/monitoring/pull/108