search

openebs / monitoring

OpenEBS Monitoring add-on. A set of Grafana, Prometheus, and alert manager plugins.
Apache License 2.0
32 stars 20 forks source link

chore(chart): check CRDs available before installing prometheus resources #108

Closed cmontemuino closed 2 months ago

cmontemuino commented 9 months ago

Prometheus resources should not be rendered unless Prometheus CRDs are available.

This changeset includes an extra option to override the apiVersion Prometheus provides.

close https://github.com/openebs/monitoring/issues/107

avishnu commented 2 months ago

There is a conflict that needs resolution.

abhilashshetty04 commented 2 months ago

Hi @cmontemuino , Thanks for thr PR. Can you please remove chart bump from your commit. We will cherry-pick your commit on PR which will have chart bump.

cmontemuino commented 2 months ago

Hi @cmontemuino , Thanks for thr PR. Can you please remove chart bump from your commit. We will cherry-pick your commit on PR which will have chart bump.

Hi @abhilashshetty04. I did a rebase against latest changes and kept file Chart.yaml unchanged.

cmontemuino commented 2 months ago

Changes from this PR have been cherry-picked in https://github.com/openebs/monitoring/pull/119