search

openebs / monitoring

OpenEBS Monitoring add-on. A set of Grafana, Prometheus, and alert manager plugins.
Apache License 2.0
28 stars 20 forks source link

[fix] Jiva & cStor volume dashboard #28

Closed Ab-hishek closed 3 years ago

Ab-hishek commented 3 years ago

Issue: JIva volume dashboard were showing data for volumes other than jiva provisoned ones. Similar is the case with cStor volume dashboard.

Why was this happening?

Jiva volume dashboard -> When there were no jiva volumes in the cluster, the dashboard template variable openebs_jiva_label had empty string value. And filtering openebs volumes upon empty jiva label gave us a list of all OpenEBS volumes(that were not jiva provisioned volumes i.e cstor volumes because openebs_size_of_volumes only exports details about jiva and cstor volumes).

Similar explanation for cstor volume dashboard.

Fix: Instead of only using single variable openebs_jiva_label for filtering jiva volumes, we also take care of checking whether it is not a cstor volume by adding an extra condition for cstor label --> openebs_cstor_labels= ""(empty). This will filter out only jiva provisoned volumes.

Signed-off-by: Abhishek Agarwal abhishek.agarwal@mayadata.io

Sanjay1611 commented 3 years ago

Will we have to add monitoring for mayastor too? Just wanted to check if another condition would be needed for that one ?

Ab-hishek commented 3 years ago

In the future -> yes. But as of now, we don't have any info about mayastor metrics.

kmova commented 3 years ago

Also, with Mayastor - we may not really use the same metric label called openebs_size_of_volume