search

openebs / monitoring

OpenEBS Monitoring add-on. A set of Grafana, Prometheus, and alert manager plugins.
Apache License 2.0
31 stars 20 forks source link

Adding NPD #32

Closed Sanjay1611 closed 3 years ago

Sanjay1611 commented 3 years ago

Signed-off-by: Sanjay Nathani sanjay.nathani@mayadata.io

This PR adds NPD as an optional deployment in the chart. The other custom configurations can also be edited and added in the values.yaml accordingly from here

avishnu commented 3 years ago

Do we need to upgrade the chart version? There is a linting error..

rajaSahil commented 3 years ago

@Sanjay1611 Please add all the configuration used in values.yaml in the README.

Ab-hishek commented 3 years ago

@Sanjay1611 You can also update all the metrics provided by npd in the docs folder as a sepearte md file.

Sanjay1611 commented 3 years ago

@Sanjay1611 You can also update all the metrics provided by npd in the docs folder as a sepearte md file.

@Ab-hishek I think instead of maintaining a sepearte md file for these metrics we can directly attach the link to parameters for the user to visit. Like for npd we can attach this link https://artifacthub.io/packages/helm/deliveryhero/node-problem-detector Helps a user to have a wider understanding.

Ab-hishek commented 3 years ago

This link provides only helm configuration fields. Metrics docs would contain all the metrics(or events) which node problem detector exports which will be used for monitoring.

avishnu commented 3 years ago

The pending review comments will be addressed in subsequent PRs.