search

openebs / openebs

Most popular & widely deployed Open Source Container Native Storage platform for Stateful Persistent Applications on Kubernetes.
https://www.openebs.io
Apache License 2.0
8.76k stars 928 forks source link

Write unit test for openebs/pkg/provisioner/cas_provision.go #1914

Closed princerachit closed 4 years ago

princerachit commented 5 years ago

Write UT for cas_provision.go.

Please comment if you want to be assigned for this issue.

Help links: Contributors guide Guide to write unit tests in golang Reference on how we write UT

Note:

  1. We only make use of standard "testing" library provided by go. Please do not add external dependency such as 'assert' etc
  2. Checkout new branch from release branch and once done raise a PR against the same.
  3. Don't forget to join hacktoberfest2018 channel on our slack workspace.
swetabehera commented 5 years ago

@princerachit Can you please assign this to me?

princerachit commented 5 years ago

@swetax go ahead!

princerachit commented 5 years ago

This issue is available again. Please comment to get assigned.

sourabh1031 commented 5 years ago

@princerachit i would like to work on this.Please tell the prerequisite to solve this.i am new here and familiar with basics of go.

princerachit commented 5 years ago

@sourabh1031 this issue has following functions that are required to be tested. NewOpenEBSCASProvisioner -> knowledge of kubernetes would be helpful, but not strictly required. GetAccessModes Setlink

See if this link helps with first function https://medium.com/@e_frogers/unit-testing-with-kubernetes-client-go-283b11aaa7db

princerachit commented 5 years ago

Would you like to take it? @sourabh1031

sourabh1031 commented 5 years ago

I am ready to work

princerachit commented 5 years ago

Sure go ahead. And let us know if you face problems. Also make sure you read contributors guide and DCO sign off your PR.

sourabh1031 commented 5 years ago

@princerachit can you please give me more time as i have learnt about basics of k8s and OpenEBS by now.

princerachit commented 5 years ago

Sure @sourabh1031

sourabh1031 commented 5 years ago

@princerachit it will be better if someone can hack this issue because i am learning golang it will take me little time so if any just pings here you can assign this and sorry for my failure

github-actions[bot] commented 4 years ago

Issues go stale after 30d of inactivity.