search

openebs / openebsctl

`openebsctl` is a kubectl plugin to manage OpenEBS storage components.
Apache License 2.0
30 stars 21 forks source link

Update headings for CVRs under CStor vol describe #137

Closed vharsh closed 2 years ago

vharsh commented 2 years ago

fixes: #135

Uses better terms to denote, Total and Free under cstor volume describe output so that users don't think of it like Total=Used+Free(and get confused when Total < Used) outright but rather understand that cvr.spec.capacity.Total is zfs used and cvr.spec.capacity.Used is zfs logical referenced, wherein the earlier total can include all descendants like snapshots and is the actual zeros and ones written on the disk post compression(including snapshots, maybe clones, etc), where-as the earlier used refers to the data which the application(s) have written to the pool(minus the compression).

Co-Authored-by: Mayank Patel (@mynktl) mayank.patel@mayadata.io Signed-off-by: Harsh Vardhan harsh.vardhan@mayadata.io

codecov-commenter commented 2 years ago

Codecov Report

Merging #137 (2179422) into develop (c55d1b6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #137   +/-   ##
========================================
  Coverage    68.35%   68.35%           
========================================
  Files           25       25           
  Lines         2051     2051           
========================================
  Hits          1402     1402           
  Misses         634      634           
  Partials        15       15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c55d1b6...2179422. Read the comment docs.