openebs / velero-plugin

Velero plugin for backup/restore of OpenEBS cStor volumes
https://docs.openebs.io
Apache License 2.0
63 stars 32 forks source link

[feat request] zfs snapshots #175

Closed jr0dd closed 3 years ago

jr0dd commented 3 years ago

I've been digging through all your documentation and not finding an answer. What I was hoping to achieve was having the velero plugin take a zfs snapshot when it backs up to minio. Even better if the plugin cleared them out according to the ttl in the schedule. This is just to able to do a quick rollback if needed. Attaching the snapshot and backup locations I'm currently using.

----
apiVersion: velero.io/v1
kind: VolumeSnapshotLocation
metadata:
  name: zfspv
  namespace: velero
spec:
  config:
    bucket: velero
    insecureSkipTLSVerify: "true"
    namespace: openebs
    prefix: zfs
    provider: aws
    region: minio
    s3ForcePathStyle: "true"
    s3Url: https://minio.minio:443
  provider: openebs.io/zfspv-blockstore
---
apiVersion: velero.io/v1
kind: BackupStorageLocation
metadata:
  name: default
  namespace: velero
spec:
  config:
    insecureSkipTLSVerify: "true"
    region: minio
    s3ForcePathStyle: "true"
    s3Url: https://minio.minio:443
  default: true
  objectStorage:
    bucket: velero
  provider: aws
pawanpraka1 commented 3 years ago

What I was hoping to achieve was having the velero plugin take a zfs snapshot when it backs up to minio.

The plugin already does that, it takes the snapshot of the volume and sends that to configured backup location. See if this doc is helpful https://github.com/openebs/zfs-localpv/blob/develop/docs/backup-restore.md

jr0dd commented 3 years ago

What I was hoping to achieve was having the velero plugin take a zfs snapshot when it backs up to minio.

The plugin already does that, it takes the snapshot of the volume and sends that to configured backup location. See if this doc is helpful https://github.com/openebs/zfs-localpv/blob/develop/docs/backup-restore.md

Thanks. That’s where I gathered most of my information for the yaml’s. I’m trying to just take regular zfs snapshots and not send them anywhere as well as sending to minio for disaster recovery. I can schedule zfs snapshots of the parent dataset that the pvc’s are on through the underlying os, but figured velero and the plug-in would handle things more gracefully.

pawanpraka1 commented 3 years ago

@jr0dd this is a new feature request. Can you convert this issue to a new requirement, we will add this to our roadmap.

@jr0dd would you like to mention your use case in our Adopters.md openebs/openebs#2719.

jr0dd commented 3 years ago

@jr0dd this is a new feature request. Can you convert this issue to a new requirement, we will add this to our roadmap.

@jr0dd would you like to mention your use case in our Adopters.md openebs/openebs#2719.

yeah you can mention me wherever you please. I will create a new issue as a feature request, since it won't let me change the label.

jr0dd commented 3 years ago

Closing this in favor of the new issue as a feature request. https://github.com/openebs/velero-plugin/issues/176