155 gone and non html content

openeduhub / metalookup

Provide metadata about domains w.r.t accessibility, licencing, adds, etc.

GNU General Public License v3.0

5 stars 0 forks source link

155 gone and non html content #157

Closed MRuecklCC closed 2 years ago

MRuecklCC commented 2 years ago

Related: #155

MRuecklCC commented 2 years ago

I am not particularly happy with the current implementation of this, but it might be ok for a start. I think it would be much cleaner to solve the whole response error code handling within the MetadataManager class and have the Extractors and Content classes raise some sort of internal exceptions as discussed here: https://github.com/openeduhub/metalookup/issues/155#issuecomment-1200948542

MRuecklCC commented 2 years ago

As we both were not happy with it, but I built the playwright changes on it, I kind of need some of the stuff. However, I merged it together with the playwright PR #158. So all required changes are there as well. Hence I will close this without merging.