Remove playwright container dependency of unittests

openeduhub / metalookup

Provide metadata about domains w.r.t accessibility, licencing, adds, etc.

GNU General Public License v3.0

5 stars 0 forks source link

Remove playwright container dependency of unittests #163

Open MRuecklCC opened 1 year ago

MRuecklCC commented 1 year ago

The current unittests require a running playwright container. Currently this container is started in the github action so the tests work. However, it would be much cleaner (and speed up the pipeline) if this dependency could be mocked consistently throughout all tests.

AC:

[ ] unittests do no longer depend on available playwright container
[ ] github action does not start playwright container
[ ] fixme in toplevel readme.md is removed

MRuecklCC commented 1 year ago

One downside of removing this entirely, is that the interaction of the Content class will no longer be testable against the real playwright API, but only against a mock replacement of it.