Refactor to only use dataclass or pydantic models, but not both; DRY - Githubissues

openeduhub / metaqs-main

Backend Service providing Information about Completeness of Metadata and Coverage of Topics

3 stars 1 forks source link

Refactor to only use dataclass or pydantic models, but not both; DRY #91

Closed RobertMeissner closed 2 years ago

RobertMeissner commented 2 years ago

e.g. quality output models

Proposal:

[ ] rename this to QualityOutput (or QualityResponse depending on whether the respective input is named QualityRequest or QualityInput)
[ ] rename QualityOutputModel to QualityRow
[ ] remove QualityOutput dataclass and use QualityRow instead.
[ ] In src/app/api/analytics/storage.py, PendingMaterials is defined as dataclass. Elsewhere, it is defined as pydantic model. Choose one basemodel and use that