search

openedx-unsupported / configuration

A collection of edx configuration scripts and utilities that edx.org uses to deploy openedx.
GNU Affero General Public License v3.0
823 stars 969 forks source link

Revert "temp: Add Atlas pull_translations back in, but with debug logging" #7125

Closed timmc-edx closed 9 months ago

timmc-edx commented 9 months ago

Reverts openedx/configuration#7122 -- the final compilejs step was producing the following npm-ci error:

npm ERR! While resolving: karma-selenium-webdriver-launcher@0.0.4
npm ERR! Found: selenium-webdriver@3.4.0
npm ERR! node_modules/selenium-webdriver
npm ERR!   dev selenium-webdriver@"3.4.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer selenium-webdriver@"^2.44.0" from karma-selenium-webdriver-launcher@0.0.4
npm ERR! node_modules/karma-selenium-webdriver-launcher
npm ERR!   dev karma-selenium-webdriver-launcher@"0.0.4" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: selenium-webdriver@2.53.3
npm ERR! node_modules/selenium-webdriver
npm ERR!   peer selenium-webdriver@"^2.44.0" from karma-selenium-webdriver-launcher@0.0.4
npm ERR!   node_modules/karma-selenium-webdriver-launcher
npm ERR!     dev karma-selenium-webdriver-launcher@"0.0.4" from the root project
timmc-edx commented 9 months ago

compilejs is called at the end of the pull_translations make recipe, after the Atlas-specific bits: https://github.com/openedx/edx-platform/blob/22ada3b939502c837b2e454c7f8c61fb835c5ca5/Makefile#L89

I can't readily separate it out. (Also, I don't know enough about what all of these commands are doing and how they related to each other.)