feat: Pull edxapp translations via Atlas - Githubissues

openedx-unsupported / configuration

A collection of edx configuration scripts and utilities that edx.org uses to deploy openedx.

GNU Affero General Public License v3.0

823 stars 969 forks source link

feat: Pull edxapp translations via Atlas #7128

Closed timmc-edx closed 9 months ago

timmc-edx commented 9 months ago

This is to support OEP-58: https://docs.openedx.org/projects/openedx-proposals/en/latest/architectural-decisions/oep-0058-arch-translations-management.html

Changes since the https://github.com/openedx/configuration/pull/7119 attempt:

Move to just after main requirements are installed (just for faster feedback during testing, really)
Use already-installed openedx-atlas
Use variant-agnostic EDX_PLATFORM_SETTINGS rather than DJANGO_SETTINGS_MODULE
Use Ansible environment field for env vars
Drop set -eu -o pipefail since the script is now simple

Most importantly, https://github.com/openedx/edx-platform/pull/34306 has since merged, so we don't have to worry about the NPM conflicts we were getting previously.

Configuration Pull Request

Make sure that the following steps are done before merging:

[x] Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
[x] If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
[x] Performed the appropriate testing.
[x] Think about how this change will affect Open edX operators and update the wiki page for the next Open edX release if needed

timmc-edx commented 9 months ago

It doesn't appear that edxapp uses the git_clone role, at least not directly. (It does use edx-themes, which uses git_clone, but for a different repo.)

This is definitely something to watch out for in other repos, but I don't think it would be relevant for 2U, at least -- we provision brand new hosts and cut AMIs, and then deploy those AMIs. The Ansible scripts only get run once.