search

openedx-unsupported / edx-analytics-configuration

GNU Affero General Public License v3.0
8 stars 28 forks source link

Upgrade to ansible version 1.9.3-rc1-edx. #27

Closed smarnach closed 8 years ago

smarnach commented 8 years ago

JIRA ticket: OLIVE-18

This is a replacement for #19, which got closed and can't be re-opened. See also edx/edx-analytics-pipeline#209

@mulby Can you please take a look?

openedx-webhooks commented 8 years ago

Thanks for the pull request, @smarnach! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?repo=edx%2Fedx-analytics-configuration&number=27

e0d commented 8 years ago

After small comment, :+1:

mulby commented 8 years ago

:+1:

smarnach commented 8 years ago

@e0d @mulby Thanks! I'll wait for @feanil to comment before merging.

smarnach commented 8 years ago

@e0d @mulby I just noticed I don't have write permission for this repo, so one of you will have to merge this.

smarnach commented 8 years ago

@feanil Thanks for confirming. I've changed the version to the edx fork of 1.9.3 now, since I'm not sure this would work with 2.x, and it probably makes sense to use the same version as in the configuration repo anyway.

@e0d @mulby Could one of you please merge the PR?

mulby commented 8 years ago

How critical is this change? It will require us to update all of our jenkins jobs I think...

I encountered 2 major issues:

  1. Ansible wouldn't install using distribute, I had to go into the advanced settings for the virtualenv builder in jenkins and switch it to "setuptools". I would have to do this on all of our jobs.
  2. When I try to run with our standard EXTRA_VARS I get the following error message: "ERROR: Expecting property name enclosed in double quotes: line 2 column 3 (char 4)"
smarnach commented 8 years ago

@mulby That's unfortunate. We've been using the updated version for a while and didn't run into any problems. The reason for this upgrade were problem with the old verison @mtyaka experienced, see https://github.com/edx/edx-analytics-pipeline/pull/209#issuecomment-191629410. Matjaz, do you have any additional comments?

mtyaka commented 8 years ago

It would make sense to revisit this after we get jenkins setup automated.