search

openedx-unsupported / edx-analytics-configuration

GNU Affero General Public License v3.0
8 stars 28 forks source link

Configurable jenkins external port #37

Closed e-kolpakov closed 8 years ago

e-kolpakov commented 8 years ago

Description: Allow jenkins port to be overridden. Motivation: Having dedicated VM for jenkins scheduler might be a bit too much, since it perfectly works alongside Insights. However, in such case, jenkins binds to 80 port first, blocking insights from default HTTP port. With this PR it becomes possible to override default jenkins port and allow Insights to listen on default HTTP port. JIRA: OSPR-1241

Testing instructions:

  1. Create file with override variables: vars.yml
  2. Add jenkins_external_port: 8080 to vars.yml
  3. Run playbook with `ansible-playbook --extra-vars=@"/path/to/vars.yml"
  4. Ensure Jenkins listens on specified port and port 80 is free.
openedx-webhooks commented 8 years ago

Thanks for the pull request, @e-kolpakov! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?number=37&repo=edx%2Fedx-analytics-configuration

openedx-webhooks commented 8 years ago

Thanks for the pull request, @e-kolpakov! I've created OSPR-1241 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information.

nedbat commented 8 years ago

@mulby to my eyes, looks like a simple change :)

mulby commented 8 years ago

@e-kolpakov this version of the role is deprecated, you want to change the one in edx/configuration

e-kolpakov commented 8 years ago

Closed in favor of https://github.com/edx/configuration/pull/2977