search

openedx-unsupported / edx-analytics-configuration

GNU Affero General Public License v3.0
8 stars 28 forks source link

Do full audit of emr module argument types #77

Closed pwnage101 closed 5 years ago

pwnage101 commented 5 years ago

This should fix issues where the vpc_subnet_id argument is always interpreted as string in the module, even if we pass a list.

Audit was based on the types specified in boto3 docs: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/emr.html

Testing

Three tests:

description expected actual link
vpc_subnet_id is a list success success http://jenkins.analytics.edx.org/view/all/job/debug-pipeline-job/291/console
vpc_subnet_id is a string success success http://jenkins.analytics.edx.org/view/all/job/debug-pipeline-job/292/console
vpc_subnet_id is a dict ValueError ValueError http://jenkins.analytics.edx.org/view/all/job/debug-pipeline-job/293/console