openedx-unsupported / edx-analytics-pipeline

GNU Affero General Public License v3.0
91 stars 116 forks source link

SE-1032 Adds option to store anonymous user events in module_engagement hive table (ironwood.master) #749

Closed pomegranited closed 5 years ago

pomegranited commented 5 years ago

Cherry-picked from https://github.com/edx/edx-analytics-pipeline/pull/734

We have tested this branch on our client who's running the Ironwood Analytics Pipeline, and it's working smoothly there.

Reviewers

CC @nedbat

Analytics Pipeline Pull Request

Make sure that the following steps are done before merging:

openedx-webhooks commented 5 years ago

Thanks for the pull request, @pomegranited! I've created OSPR-3756 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

brianhw commented 5 years ago

@nedbat Any reason I shouldn't just merge this?

nedbat commented 5 years ago

No reason not to!

natabene commented 5 years ago

@pomegranited Thank you for your contribution. @brianhw Do you want to merge now or do you want to have a second reviewer from edX look at it first? Up to you

openedx-webhooks commented 5 years ago

@pomegranited 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

pomegranited commented 5 years ago

Thank you @brianhw and @nedbat and @natabene !