openedx-unsupported / edx-analytics-pipeline

GNU Affero General Public License v3.0
91 stars 116 forks source link

ENT-2363 | updated Enterprise Enrollment Report query to support entitlements enrollments #770

Closed HammadAhmadWaqas closed 4 years ago

HammadAhmadWaqas commented 4 years ago

https://openedx.atlassian.net/browse/ENT-2363

Make sure that the following steps are done before merging:

codecov[bot] commented 4 years ago

Codecov Report

Merging #770 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   74.53%   74.53%           
=======================================
  Files         211      211           
  Lines       24193    24193           
=======================================
  Hits        18032    18032           
  Misses       6161     6161
Impacted Files Coverage Δ
...alytics/tasks/enterprise/enterprise_enrollments.py 83.87% <ø> (ø) :arrow_up:
...ks/tests/acceptance/test_enterprise_enrollments.py 40% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01c4980...0940b9d. Read the comment docs.

HammadAhmadWaqas commented 4 years ago

@brianhw can you please review it again. I have added a test to support my changes. In test I have added an entitlement enrollent.