openedx-unsupported / edx-analytics-pipeline

GNU Affero General Public License v3.0
91 stars 116 forks source link

Numpy version update #782

Closed AhtishamShahid closed 4 years ago

AhtishamShahid commented 4 years ago

Changes

@brianhw : Tagging you here since upgrading the lib needed to change the tests. Can you please look at the changes and suggest what should be the better way to handle the rounding?

codecov[bot] commented 4 years ago

Codecov Report

Merging #782 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   74.54%   74.54%           
=======================================
  Files         211      211           
  Lines       24085    24085           
=======================================
  Hits        17953    17953           
  Misses       6132     6132
Impacted Files Coverage Δ
...ics/tasks/insights/tests/test_module_engagement.py 99.71% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b91b00...eeaf649. Read the comment docs.

brianhw commented 4 years ago

201712-pipcompile.txt

I'm attaching my notes from starting this work two years ago. Some of the updates have since been done (in part), such as htmllib (and luigi as far as 2.7.1), but others like the google update have not yet been done and have a few challenges. I think the branch on Python 3 discovery has included in it the work for upgrading ansible, so you could borrow those modifications from there.

Good luck!

AhtishamShahid commented 4 years ago

201712-pipcompile.txt

I'm attaching my notes from starting this work two years ago. Some of the updates have since been done (in part), such as htmllib (and luigi as far as 2.7.1), but others like the google update have not yet been done and have a few challenges. I think the branch on Python 3 discovery has included in it the work for upgrading ansible, so you could borrow those modifications from there.

Good luck!

I have updated PR , so now in this PR only numpy version is updated otherwise it will increase the scope of the issue.

brianhw commented 4 years ago

Sorry for the delay. Our Jenkins acceptance tests have not been running properly, so we've not been able to test PRs before merging to master. I'm making progress on getting some subset of them working. Once I confirm master is passing, then we can run acceptance tests for this branch.